Transcode audio to keep multichannel support #1466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
cewert
added
new-feature
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be reviewed. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transcode multichannel audio files that downmix to stereo to keep multichannel support i.e. 6+ channel AAC files can be played by the device but downmix to stereo
Everything works with one big exception - video files that are transcoded to preserve multichannel audio play as the should but fast forward and rewind no longer work as well as the length of the video showing 0.
This code was originally from #1366. Making a PR for it so the rest of #1366 can be reviewed and merged.