Update WebSocket code to generated models #774
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the amazing work from @crobibero we can now (with 10.9) use the WebSocket models from the OpenAPI specification. This PR updates our implementation to use those models.
Note: subscriptions still need to be manually added to
subscriptionTypes.kt
, I don't think we can really automate that.Note2: New models are incompatible with old models because we used different names for some properties. Running the 10.9 spec with a 10.8 server and the other way around mostly works though.
Note3/reminder: Docs still need updating <-- 2024 update: will update documentation later ©️
Draft until 10.9 beta's start rolling out.