-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add quick connect (login without typing password) #1096
Conversation
ea0a973
to
bf03a7b
Compare
Aside from that this looks great! It'll be really convenient to have :) |
We are migrating to ES6, so if you want to update your files it would be excellent but not required. We are also fixing the casing of folders and files to use camelCase so please rename them to match that standard. |
I've renamed the files to use camelCase but I'm not fluent enough in JavaScript to migrate to ES6 |
No worries, that's not blocking. We'll take care of it ;) |
Do note that due to #1007, you might have to submit your API client changes to https://github.com/jellyfin/jellyfin-apiclient-javascript instead of here, though. |
Apologies for all the merge conflicts, we have been going through some drastic changes from stricter linting rules and more CI additions. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look great overall! Just a couple small pieces of feedback.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Changes
This PR adds a new login method for devices that do not have a keyboard to enter a username/password on (smart TVs) or have limited keyboard input. It is a recreation of other quick sign in solutions found in other products (such as Plex, YouTube and Amazon Prime).
Proposed login flow:
Proposed changes, feedback, and UX changes are welcome.
Related PR: Server side code
Planned features for this PR:
Issues
Closes feature request 541.