Enable and fix PiP for Safari #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the previously commented out lines that would enable Picture in Picture support for Safari. Also fixed IF condition to match the Apple developer reccomendation: https://developer.apple.com/documentation/webkitjs/adding_picture_in_picture_to_your_safari_media_controls
|
Tested working in Safari Version 12.0.3 (14606.4.5) on macOS Mojave 10.14.3 (18D42). |
Adds my name to the list, and fixes the broken links for the other users before me.
JustAMan
reviewed
Feb 3, 2019
src/bower_components/emby-webcomponents/htmlvideoplayer/plugin.js
Outdated
Show resolved
Hide resolved
dkanada
approved these changes
Feb 3, 2019
This puts the IF condition for detecting Chrome PiP support into the same line as the one that sets it up for Safari. I tested it in both browsers, as well as Firefox. In browsers where PiP is supported, they each respond to their own call and not the other (Safari only responds to the Webkit check, Chrome only responds to the document check). Firefox currently supports neither standard, so there's no issue there.
cvium
requested changes
Feb 4, 2019
src/bower_components/emby-webcomponents/htmlvideoplayer/plugin.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: anthonylavado <anthonylavado@users.noreply.github.com>
cvium
reviewed
Feb 4, 2019
src/bower_components/emby-webcomponents/htmlvideoplayer/plugin.js
Outdated
Show resolved
Hide resolved
Remove extra newline Co-Authored-By: anthonylavado <anthonylavado@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the previously commented out lines that would enable Picture in Picture support for Safari.
Also fixed IF condition to match the Apple developer reccomendation: https://developer.apple.com/documentation/webkitjs/adding_picture_in_picture_to_your_safari_media_controls
Fixes #101.