Exit fullscreen automatically after video playback ends #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustAMan
approved these changes
Feb 18, 2019
|
I think this works as a solution, given what we have already. It's not the best fix for #923 but it is a fix. Slated for inclusion in 10.2.1 as a bugfix. |
joshuaboniface
approved these changes
Feb 18, 2019
|
Is this necessary ? Is there any way to re-enable fullscreen remotely from the android app without leaving the couch ? :) |
|
Maybe we could keep it in fullscreen if the display mode is set to "TV" and leave it on the other display modes? |
|
Maybe we should automatically go full-screen when in TV mode? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, the video element or its parent container should be fullscreened and none of this would be necessary, BUT video osd is in a separate container, so video element cannot be fullscreened without the osd disappearing...
So this change is the next best solution I could think of. Maybe I'll look into refactoring videoosd to wrap the video element.
Thoughts?
Fixes jellyfin/jellyfin#923