Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top offset and bottom offset margins in emby-scrollbuttons #144

Merged
merged 1 commit into from
Mar 10, 2019
Merged

Add top offset and bottom offset margins in emby-scrollbuttons #144

merged 1 commit into from
Mar 10, 2019

Conversation

grafixeyehero
Copy link
Member

@grafixeyehero grafixeyehero commented Feb 18, 2019 •
edited
Loading

Issues
Arrow buttons cover the options menu in the dash #142

Before

before

After

after

optional removing gradient

optional

JustAMan
JustAMan reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@JustAMan JustAMan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks okay, but I would like to see a pair of "before" and "after" screenshots (hard to validate CSS in my head, you know 😄 )

UPD: you were faster in uploading screenshots than me requesting them :)

JustAMan
JustAMan approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@JustAMan JustAMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grafixeyehero
Copy link
Member Author

grafixeyehero commented Feb 19, 2019 •
edited
Loading

@JustAMan but which one did u prefer the 2nd or the 3rd

@JustAMan
Copy link
Contributor

I dunno, probably 2nd to better see where is that scroll thing... Though maybe remove gradient from it? Most our ui is flat.

@joshuaboniface joshuaboniface changed the title margining top offset and bottom offset emby-scrollbuttons Add top offset and bottom offset margins in emby-scrollbuttons Mar 10, 2019
@joshuaboniface joshuaboniface merged commit 84f2315 into jellyfin:master Mar 10, 2019
@grafixeyehero grafixeyehero deleted the dev branch March 22, 2019 22:44
@T0W1 T0W1 mentioned this pull request May 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaboniface joshuaboniface joshuaboniface approved these changes

@JustAMan JustAMan JustAMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grafixeyehero @JustAMan @joshuaboniface