Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix slider step #4758

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Fix slider step #4758

merged 1 commit into from
Sep 8, 2023

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Aug 23, 2023 •
edited
Loading

Changes
Use the value of the step attribute if no keyboard steps are specified.

Issues
Fixes #4753

Requires manual backporting (indentation change in the master).

@dmitrylyzo
Fix slider step
7d27596 
Use the value of the `step` attribute if no keyboard steps are specified.
@dmitrylyzo dmitrylyzo added bug Something isn't working ui & ux This PR or issue mainly concerns UI & UX labels Aug 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dmitrylyzo dmitrylyzo mentioned this pull request Aug 26, 2023
Merged
@thornbill thornbill added the stable backport Backport into the next stable release label Sep 7, 2023
@thornbill thornbill added this to the v10.9.0 milestone Sep 7, 2023
@thornbill thornbill merged commit a5feddb into jellyfin:release-10.8.z Sep 8, 2023
@thornbill thornbill modified the milestones: v10.9.0, v10.8.11 Sep 8, 2023
@dmitrylyzo dmitrylyzo mentioned this pull request Sep 24, 2023
Merged
@dmitrylyzo dmitrylyzo deleted the fix-slider-step branch September 24, 2023 22:51
@dmitrylyzo dmitrylyzo removed the stable backport Backport into the next stable release label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Milestone
v10.8.11
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitrylyzo @thornbill