Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify subtitle sync #4760

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Simplify subtitle sync #4760

merged 3 commits into from
Sep 26, 2023

Conversation

dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented Aug 26, 2023 •
edited
Loading

Changes

  • Fix slider rounding.
  • Pass slider value to the bubble text generators to be able to use it directly, rather than converting from percentages.
  • Use slider to round and limit offset.

@dmitrylyzo dmitrylyzo added the enhancement Improve existing functionality or small fixes label Aug 26, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@dmitrylyzo dmitrylyzo mentioned this pull request Aug 26, 2023
Merged
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@dmitrylyzo dmitrylyzo changed the title Pass slider value to bubble text generators Simplify subtitle sync Sep 26, 2023
@dmitrylyzo dmitrylyzo marked this pull request as ready for review September 26, 2023 11:47
@dmitrylyzo dmitrylyzo requested a review from a team as a code owner September 26, 2023 11:47
@thornbill thornbill added this to the v10.9.0 milestone Sep 26, 2023
@thornbill thornbill merged commit c1ef338 into jellyfin:master Sep 26, 2023
@dmitrylyzo dmitrylyzo deleted the slider-bubble-value branch September 26, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Milestone
v10.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dmitrylyzo @thornbill