HLS direct play #4761
Merged
HLS direct play #4761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
force-pushed
the
hls-direct-play
branch
2 times, most recently
from
85b0393
to
e2e31e7
Compare
dmitrylyzo
added
playback
thornbill
reviewed
Sep 8, 2023
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
dmitrylyzo
force-pushed
the
hls-direct-play
branch
from
e2e31e7
to
d75df4a
Compare
dmitrylyzo
force-pushed
the
hls-direct-play
branch
from
d75df4a
to
251a601
Compare
dmitrylyzo
commented
Sep 13, 2023
| * @returns _true_ if the media source is an HLS stream, _false_ otherwise. | ||
| */ | ||
| export function isHls(mediaSource: MediaSourceInfo|null|undefined): boolean { | ||
| return (mediaSource?.TranscodingSubProtocol || mediaSource?.Container) === 'hls'; |
There was a problem hiding this comment.
Hmm, jellyfin/jellyfin#10153 will change the type of TranscodingSubProtocol.
There was a problem hiding this comment.
I think it will be fine as long as hls matches the enum value.
thornbill
reviewed
Sep 14, 2023
dmitrylyzo
force-pushed
the
hls-direct-play
branch
from
251a601
to
1684acd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
Fixes #4479
It works on 10.8 too.