-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the series and season Play button play the next episode #4827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the new version for its sleek appearance. But we will miss episodes when watch status is:
S01E01 v
S01E02 v
S01E03 <-- we unmarked it as 'Played', playback starts from here
S02E01 v <-- this will be skipped
S02E02
S02E03
If this behavior is acceptable, below are some necessary changes.
If no, your first attempt, but without the outer Promise
.
UPD:
Logically, your first attempt has better behavior - you can rewatch the episodes in the correct order without skipping.
Please revert the changes to the first attempt, but without the outer Promise
. Actually, that's what I expected.
Given that the |
629537c
to
d5fdb82
Compare
Similar to my suggestion for seasons, series currently fails if it is complete. |
031445a
to
10bb08a
Compare
Kudos, SonarCloud Quality Gate passed! |
Cloudflare Pages deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've fixed style to my taste 😄
I guess we will need to change UserData.Played
to something else when that discussion is resolved.
but it does not continue a partially watched episode.
If you want to fix resuming, you need to pass startPositionTicks
in options
somehow:
const startPosition = playOptions.startPositionTicks; |
But this can be done in another PR.
Also, for the future, it's better to create a separate branch for PR.
Changes
Instead of starting the series or season at the first episode this queues up the next unwatched episode. If the selection is fully watched it marks all unplayed and starts over.
Issues
Partially Fixes #2570 but it does not continue a partially watched episode.