Fix FilterMenu not saving simple filters #4836
Conversation
| for (let i = 0, length = elems.length; i < length; i++) { | ||
| if (elems[i].checked) { | ||
| videoTypes.push(elems[i].getAttribute('data-filter')); | ||
| for (const elem of context.querySelectorAll('.chkVideoTypeFilter')) { |
There was a problem hiding this comment.
forEach is more portable (for legacy) than for..of. 🤔
for..of is transpiled into a large block with iterator.
☝️ this bothers me.
There was a problem hiding this comment.
It sounds like we should setup some eslint rules to prevent us from using some of these language features that make generated code more complex since it has came up a few times now. I can also disable related rules on the sonar side as needed.
There was a problem hiding this comment.
Tried eslint-plugin-no-for-of-loops: 147 errors 😅
There was a problem hiding this comment.
Do you want to change the usages here or leave it as is?
dmitrylyzo
force-pushed
the
fix-filtermenu
branch
from
85be670
to
37c69e3
Compare
dmitrylyzo
force-pushed
the
fix-filtermenu
branch
from
37c69e3
to
fc37f82
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Cloudflare Pages deployment
|
Regression 6341a71
Changes
Issues
FilterMenu doesn't save simple filters because of
elemsoverride.