-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix changing filters not resetting multiselected media cards #5377
Fix changing filters not resetting multiselected media cards #5377
Conversation
a5fa2cb
to
fdce2e2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
@ConnorS1110 could you resolve the conflicts here? Now that 10.9 is finally out let's work on getting this in. 👍 |
fdce2e2
to
b2dbae0
Compare
@thornbill fixed the merge conflict and looks like everything is still good |
Cloudflare Pages deployment
|
Sorry got the delay. I’ve been a bit busy dealing with bugs in 10.9 but I think that is finally starting to settle down. This would probably be a good candidate for 10.9 if you don’t mind going through the rebase process. |
Do you mean a candidate for 10.10? @thornbill |
No I mean 10.9 since it is a relatively small bug fix we can get it in a patch release. You can follow the process described here to update this PR to target the release branch: #5680 (comment) |
b2dbae0
to
fba3cc4
Compare
This comment was marked as outdated.
This comment was marked as outdated.
I don't think I've done this correctly, but I can't figure out what I did wrong. I rebased and accepted the current changes for everything. |
fba3cc4
to
100ed92
Compare
Ok I think? I fixed it. I am assuming I was supposed to literally remove all the commit lines that were not mine when doing the rebase |
It just grabbed all commits to your branch. If you are using Git CLI, use interactive mode ( Some GUI tools can do interactive rebasing too, but I don't use any of them. UPD: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor note, we are somewhat inconsistent with spacing after a function name, but we should prefer no space.
100ed92
to
84e7b59
Compare
Quality Gate passedIssues Measures |
Fix changing filters not resetting multiselected media cards Original-merge: 798b408 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: Bill Thornton <thornbill@users.noreply.github.com>
Changes
Multi-selected options are now cleared by calling
hideSelections
from themultiSelect
component when a change is triggered in thefilterdialog
component.hideSelections
is also called in thelist
controller when filters have been changed and there actually filters being applied instead of removed.Issues
Fixes #5209