Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fMP4 is enabled by default only for the following browsers. It is unchecked on others.
(browser.safari || browser.firefox || browser.chrome || browser.edgeChromium)
Perhaps you want to disable it completely to avoid confusing users?
jellyfin-web/src/scripts/browserDeviceProfile.js
Line 747 in d60ddeb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to ask if we wanted it completely disabled to be honest but I would prefer to have the option there, maybe with an edited description to state that it can cause problems on certain platforms. I can't remember there being any problems with SDR content and at least in this thread there isn't any info on Tizen's behaviour when it comes to item resume when fmp4 is enabled. Also, correct me if I'm wrong but as far as I can tell changing this conditional to "force disable" fmp4 would just make the checkbox have absolutely no effect, no matter its state. I can see this causing confusion in other users. A better option in my opinion would be to hide the checkbox altogether to completely disable the feature, but I would have to check if that's easily achievable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my Tizen 4 TV, fMP4 requires the transcoding job to complete. But I have no idea if it works on modern models.
This checkbox is part (sort of) of the device profile settings, like
Enable DTS
andEnable TrueHD
. So I agree with @GeorgeH005, we should leave it up to the user and add a warning.Btw, Tizen isn't detected as Chrome, so this option wasn't turned on by default.