Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playback interceptor rejecting #5573

Merged
merged 2 commits into from
May 21, 2024
Merged

Fix playback interceptor rejecting #5573

merged 2 commits into from
May 21, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Fixes a regression from Show error message on playback failure #5402 where access checks fall through to getting the saved bitrate when rejecting allowing users to play media they don't have access to after closing the dialog

The code is pretty gross, but I don't want to touch this too much in a backport PR

Issues
Fixes #5568

@thornbill thornbill added bug Something isn't working regression We broke something stable backport Backport into the next stable release labels May 20, 2024
@thornbill thornbill added this to the v10.9.3 milestone May 20, 2024
@thornbill thornbill requested a review from a team as a code owner May 20, 2024 21:53
@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 70b9aa4
Status ✅ Deployed!
Preview URL https://59cbcae3.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

github-actions[bot]
github-actions bot previously requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/components/playback/playbackmanager.js Show resolved Hide resolved
@thornbill thornbill dismissed github-actions[bot]’s stale review May 21, 2024 16:13

leaving a fixme comment because refactoring this in a backport is asking for trouble

@thornbill thornbill merged commit add01e3 into jellyfin:release-10.9.z May 21, 2024
12 checks passed
@thornbill thornbill deleted the fix-playback-access branch May 21, 2024 20:17
joshuaboniface pushed a commit that referenced this pull request May 25, 2024
@thornbill @joshuaboniface
Backport pull request #5573 from jellyfin-web/release-10.9.z
80abbb4 
Fix playback interceptor rejecting

Original-merge: add01e3

Merged-by: thornbill <thornbill@users.noreply.github.com>

Backported-by: Joshua M. Boniface <joshua@boniface.me>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label May 25, 2024
@dmitrylyzo dmitrylyzo mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo dmitrylyzo approved these changes

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
bug Something isn't working regression We broke something
Projects
No open projects
Release 10.9.z
Status: Done
Milestone
v10.9.3
Development

Successfully merging this pull request may close these issues.
4 participants
@thornbill @jellyfin-bot @nielsvanvelzen @dmitrylyzo