Add no-cache attribute for fetch requests to /system/info/public to prevent stale server info #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should go to 10.9. |
Doxterpepper
force-pushed
the
remove-caching-system-info
branch
from
67e043b to
8494a7d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Doxterpepper
force-pushed
the
remove-caching-system-info
branch
from
8494a7d to
6805eee
Compare
|
Re targeted 1.9.z, but maybe it should go in both 1.9.z and master so it covers future releases? |
Doxterpepper
force-pushed
the
remove-caching-system-info
branch
from
6805eee to
20a301a
Compare
It will be automatically backported to the |
thornbill
added
bug
|
It should be added as a header here also: https://github.com/jellyfin/jellyfin-web/blob/release-10.9.z/src/hooks/useSystemInfo.ts#L27 |
This was referenced Jul 25, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Doxterpepper
force-pushed
the
remove-caching-system-info
branch
from
20a301a to
e0b814c
Compare
…e correct server version during upgrade
Adding no-cache Cache-Control header policy to prevent caching of server version. This ensures the correct server version is always retrieved.
thornbill
force-pushed
the
remove-caching-system-info
branch
from
cca32e8 to
f1ecb96
Compare
thornbill
approved these changes
Aug 13, 2024
|
thornbill
pushed a commit
that referenced
this pull request
Aug 13, 2024
Add no-cache attribute for fetch requests to /system/info/public to prevent stale server info Original-merge: a0e6da7 Merged-by: thornbill <thornbill@users.noreply.github.com> Backported-by: thornbill <thornbill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Issues
#5729