Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use production year for movies in video player #5765

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

venkat-karasani
Copy link
Contributor

@venkat-karasani venkat-karasani commented Jul 9, 2024

Changes
we will display production year in title for movies if it is present and else premiere date.

Issues
Fixes #5736

@venkat-karasani venkat-karasani requested a review from a team as a code owner July 9, 2024 04:08
@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Jul 11, 2024
@thornbill
Copy link
Member

Does this match the logic we use for cards and the item details page?

@thornbill thornbill added this to the v10.10.0 milestone Jul 26, 2024
@thornbill thornbill added the question Further information is requested label Jul 26, 2024
@venkat-karasani
Copy link
Contributor Author

Does this match the logic we use for cards and the item details page?

Both cards and details page seem to be using production Year if present.

card builder:
image

item details page:
image

@thornbill thornbill added enhancement Improve existing functionality or small fixes and removed enhancement Improve existing functionality or small fixes question Further information is requested labels Aug 15, 2024
@thornbill thornbill changed the title In video player, changes to display production year rather than release year for movies. Use production year for movies in video player Aug 15, 2024
@thornbill thornbill force-pushed the player-title-year-change branch from 4bb1828 to 0fd714c Compare August 15, 2024 19:51
Copy link

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 0fd714cd874a59ac52ce012a56a687fbc6367f87
Status ✅ Deployed!
Preview URL https://9602f801.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit f8e4287 into jellyfin:master Aug 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Title in video player displays release year for movies rather than production year
3 participants