Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add headings and links to plugin pages #5789

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Add headings and links to plugin pages #5789

merged 1 commit into from
Jul 15, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Adds headings and help links to the installed plugins and plugin repo page
  • Moves repositories page from drawer navigation to a settings link on the repo page

Screenshot 2024-07-15 at 10-25-05 Jellyfin
Screenshot 2024-07-15 at 10-24-46 Jellyfin

Issues
N/A

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Jul 15, 2024
@thornbill thornbill added this to the v10.10.0 milestone Jul 15, 2024
@thornbill thornbill requested a review from a team as a code owner July 15, 2024 14:28
nielsvanvelzen
nielsvanvelzen approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving the search bar to the right side of the heading (with a max size of 300-400 pixels or so) would make the pages look even better.

src/controllers/dashboard/plugins/available/index.html
<a is="emby-linkbutton" class="fab" href="#/dashboard/plugins/repositories" style="margin-left:1em;" title="${Settings}">
<span class="material-icons settings" aria-hidden="true"></span>
</a>
<a is="emby-linkbutton" rel="noopener noreferrer" class="raised button-alt headerHelpButton" target="_blank" href="https://jellyfin.org/docs/general/server/plugins/">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thought of this, not specific to this PR; it is much easier to maintain the various links to our documentation if we added all of them to a single file. That way they are named and easy to update if we refactor our docs.

@thornbill
Copy link
Member Author

I agree. I just didn't want to spend the time to style it when I plan to redo these pages soon™️. 😅

@thornbill thornbill merged commit 845d237 into jellyfin:master Jul 15, 2024
8 checks passed
@thornbill thornbill deleted the update-plugin-headings branch July 15, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@thornbill @nielsvanvelzen