Keybind C to auto select subtitle track

[BakerAO]

Keybind C to auto select subtitle track

Changes
Add c case to onKeyDown. The function selects the first available subtitle track, or if subtitles are already selected, disables them.

Issues
Feature Request: https://features.jellyfin.org/posts/1245/enable-disable-subtitles-using-a-keyboard-shortcut

[viown]

I'm not sure if the user always expects the first subtitle track to be selected as they may have different subtitle preferences.

Maybe you can use currentPlayer.streamInfo.mediaSource.DefaultSubtitleStreamIndex and fallback to streams[0].Index if it's -1. Or, alternatively, something like DefaultSubtitleStreamIndex -> Subtitle Track with 'default' flag on -> streams[0].Index.

You could also take advantage of the user's subtitle language preference, but that may be overcomplicating things as DefaultSubtitleStreamIndex should already point to the 'best' track unless it was manually changed or turned off.

You can also avoid guessing altogether if this feature instead allowed you to cycle through the subtitle tracks by repeatedly pressing C, eventually cycling back to off. Though you'd need a visual message showing which track it's currently on. This is, IMO, most preferable.

[BakerAO]

Thank you for the feedback, that makes sense. I like the idea of using DefaultSubtitleStreamIndex. I imagine most users don't want to cycle through the options (like English to French to Italian, etc), typically they just want them on or off in their language, but that would work as well.

[Shadowghost]

allowed you to cycle through the subtitle tracks by repeatedly pressing C

This might be a very bad user experience in case we are transcoding and burning in subs beause it will always restart the transcode

[viown]

Good point, I didn't consider that.

[BakerAO]

@viown and @Shadowghost, updated to use the default index if its set

[BakerAO]

Commited your change @viown, that made sense

[jellyfin-bot]

Cloudflare Pages deployment

Latest commit	122c395
Status	✅ Deployed!
Preview URL	https://2541d8ba.jellyfin-web.pages.dev
Type	🔀 Preview

View build logs

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[BakerAO]

@viown does this PR still look good to you? let me know if you want any changes

[viown]

Code-wise, it looks fine to me and it works as expected in my testing. But it would have to be approved by thornbill or another core team member in order to decide if it's a desired feature.