Add playback subscriber abstraction #6149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
approved these changes
Oct 1, 2024
|
I could give some critique about some of the events but those are already part of the playback manager so not related to this PR. |
|
Cloudflare Pages deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds an abstraction for subscribing to playback events
NOTE: Nothing is actually using this currently, but it provides the basis for segment skipping (and a lot of existing code could be refactored to use it for simplicity). I did write a
LoggingSubscriberfor testing locally, but I'm not sure that would provide any real value to actually add.Issues
N/A