Fix tags and schedule edit for parental control #6231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloudflare Pages deployment
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
viown
reviewed
Oct 20, 2024
Unfortuenately, the key is never populated in accessSchedule.js which cannot use that as a key for a list
gnattu
force-pushed
the
fix-parental-tags
branch
from
ec809b6 to
95e935a
Compare
This is better and any sane person should not set multiple schdules to be exactly the same
viown
reviewed
Oct 20, 2024
|
viown
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our callback implementation for the parental control page was quite hacky and fragile. It stopped working properly in the current master branch, likely due to updates in React. This isn't the only instance where we manipulate DOM objects directly instead of using React, so other pages may also be affected, but this one has been reported.
In the parental control page, the popup callback was added twice since
useEffectwas executed twice in each render cycle. Also, the delete tag/schedule button had no callbacks assigned because the DOM object wasn't available when the data loading hook was executing.Changes
Issues