Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move strict mode to page component #6327

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

thornbill
Copy link
Member

Changes

  • Moves StrictMode to the Page component instead of the toAsyncPageRoute function
  • Adds support for routes returning RouteObjects directly (similar to the examples in the official documentation for lazy)

Issues
N/A

@thornbill thornbill added the cleanup Cleanup of legacy code or code smells label Nov 18, 2024
@thornbill thornbill added this to the v10.11.0 milestone Nov 18, 2024
@thornbill thornbill requested a review from a team as a code owner November 18, 2024 22:00
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 18, 2024

Cloudflare Pages deployment

Latest commit e71d83a
Status ✅ Deployed!
Preview URL https://1cf3a416.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Waterfox on Windows 11. Noticed no changes.

@thornbill thornbill merged commit 33b6106 into jellyfin:master Nov 19, 2024
14 checks passed
@thornbill thornbill deleted the strict-mode-page branch November 19, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleanup of legacy code or code smells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants