Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tasks edit page to react #6565

Merged
merged 10 commits into from
Mar 5, 2025
Merged

Migrate tasks edit page to react #6565

merged 10 commits into from
Mar 5, 2025

Conversation

viown
Copy link
Member

@viown viown commented Feb 22, 2025 •
edited
Loading

Changes

  • Migrates the tasks edit page to react + TS SDK
  • Replace usage of datetime with date-fns
  • localize day of week
  • localize interval

image

Issues
Fixes #6507

@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Feb 22, 2025 •
edited
Loading

Cloudflare Pages deployment

Latest commit 709378f
Status ✅ Deployed!
Preview URL https://3cb1f919.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@viown viown added enhancement Improve existing functionality or small fixes cleanup Cleanup of legacy code or code smells labels Feb 22, 2025
@jhparker88
Copy link

Is there any particular reason to move from scheduledtasks (e.g. src/apps/dashboard/features/scheduledtasks/api/useStartTask.ts) to tasks (e.g. src/apps/dashboard/features/tasks/api/useStartTask.ts) given that "tasks" is a pretty generic name and the web UI as component is referencing to it as Scheduled Tasks?

@viown
Copy link
Member Author

viown commented Feb 23, 2025

It's mainly to be consistent with the path route. Since we use tasks under routes, we should use tasks for its feature directory also.

@viown viown marked this pull request as ready for review February 23, 2025 15:15
@viown viown requested a review from a team as a code owner February 23, 2025 15:15
github-actions bot pushed a commit to soultaco83/jellyfin-web-requeststab that referenced this pull request Mar 1, 2025
@actions-user
Merge PR jellyfin#6565 into master
3c11a43
@soultaco83
Copy link

This has resolved the issue listed in #6507

also I like the new style of it.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Mar 3, 2025
@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@viown viown force-pushed the react-tasks-edit branch from 0d4c3ef to d53c1f5 Compare March 3, 2025 15:20
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Mar 3, 2025
@viown viown force-pushed the react-tasks-edit branch from d53c1f5 to 709378f Compare March 4, 2025 07:36
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@thornbill thornbill merged commit 3c62c1d into jellyfin:master Mar 5, 2025
15 checks passed
@thornbill thornbill added this to the v10.11.0 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
cleanup Cleanup of legacy code or code smells enhancement Improve existing functionality or small fixes
Projects
None yet
Milestone
v10.11.0
Development

Successfully merging this pull request may close these issues.

Unable to edit scheduled tasks: Master Branch
5 participants
@viown @jellyfin-bot @jhparker88 @soultaco83 @thornbill