Remove HEVC SDR fallback stream #10751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The client starts playback from a stream with an average bitrate. In some cases this is HEVC SDR. After a while, the client switches to the HDR stream, but the server doesn't restart ffmpeg and the client continues playing the old stream. Since we have a VideoRange condition, the HEVC SDR fallback stream is no longer needed.
|
Is there a way to check the client name and bypass this?
|
I don't think we should use the client name to workaround this issue. Instead, we need to add some condition to the device profile.
There isn't much information in the playlist. #9121 is a softer solution. |
jellyfin-bot
added
the
merge conflict
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged. |
|
Superseded by #9121 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #9121
The client starts playback from a stream with an average bitrate. In some cases this is HEVC SDR. After a while, the client switches to the HDR stream, but the server doesn't restart ffmpeg and the client continues playing the old stream.
Since we have a
VideoRangecondition, the HEVC SDR fallback stream is no longer needed, IMO.Alternatively, we can use bitrate copying - #9121
Changes
Remove HEVC SDR fallback stream.
Issues
Fixes #8043
Fixes jellyfin/jellyfin-webos#105
Fixes jellyfin/jellyfin-tizen#163
Fixes jellyfin/jellyfin-webos#59
Fixes #5576 (#5576 (comment))
Fixes jellyfin/jellyfin-web#1190