Clean up UDP responders, and move ProductName to Public endpoint #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leaves only an answer to "Who is Jellyfin", removing older ones for EmbyServer and MediaBrowser_v2.
Moves the ProductName field over from the private system/info point to the public one, for easier identification
Missed moving this from one class to the other.
cvium
approved these changes
Apr 16, 2019
|
Please keep ProductName to both end points or you are breaking compatibility with your own API and those who may use it already. |
|
|
Sorry for the noise should have read code instead of PR comment :) |
Bond-009
approved these changes
Apr 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In
UdpServer.cs, remove the other UDP responders (embyserver, MediaBrowser_v2), and only keeps Jellyfin.In
ApplicationHost.cs, moves the ProductName entry from the “.../system/info” endpoint to the “…/system/info/public” one instead.Issues
Start of the work for #1222.