Extras: Clean filename and process NFOs #9403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shadowghost
approved these changes
Feb 27, 2023
crobibero
reviewed
Feb 27, 2023
|
Any feedback on the unit test I changed? I'm not aware of which issues that might be related to, or if my change will affect them. |
jellyfin-bot
added
the
merge conflict
- Adds regular expression to CleanStrings to remove suffix style extra naming from the name presented in JF. - Override Resolve for Extras to enable parsename - remove exclusion on parsename of extratypes
- Change test to prevent owned items from using parent NFO. Test is now in MovieNFOSaver, only movie type will use movie.nfo.
I need more information about the need for this test, to make sure I am not introducing an issue.
Apply code review Co-authored-by: Cody Robibero <cody@robibe.ro>
SenorSmartyPants
force-pushed
the
ExtraCleanAndNFO
branch
from
dd8cd8a
to
4f06154
Compare
jellyfin-bot
removed
the
merge conflict
daullmer
approved these changes
Mar 16, 2023
I added that test when I did some work on I've never used NFOs so I can't attest to the necessity of that check. I expect that if you're changing the behavior you've done some testing with various NFO and naming arrangements. |
crobibero
reviewed
Mar 19, 2023
|
@crobibero Added one test of cleaning 3 extra names. |
crobibero
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
A file named
Interview with director-interview.mkvwill now be namedInterview with directorin JF.NFO files named the same as extra file will be read for metadata.