Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect audio spatial format #9996

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Detect audio spatial format #9996

merged 3 commits into from
Jan 6, 2024

Conversation

mohd-akram
Copy link
Contributor

Support was added to FFmpeg.

Changes
Add AudioSpatialFormat property to MediaStream.

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Aug 1, 2023
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

Copy link
Contributor

@Shadowghost Shadowghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go after resolving conflicts

@jellyfin-bot jellyfin-bot removed the merge conflict Merge conflicts should be resolved before a merge label Aug 14, 2023
@mohd-akram
Copy link
Contributor Author

Thanks, rebased.

@Shadowghost
Copy link
Contributor

@mohd-akram can you please address the proposed changes so we can get this merged? Thank you!

@Bitwolfies
Copy link

Id also toss in detection for Mpeg-H 3D, not a ton of support right now but newer Denon receivers can decode it and it has software support in FFMPEG/Exoplayer.

@jellyfin-bot jellyfin-bot added the merge conflict Merge conflicts should be resolved before a merge label Nov 8, 2023
@jellyfin-bot
Copy link
Contributor

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@JPVenson JPVenson added the stale Stale and will be closed if no activity occurs label Jan 2, 2024
@jellyfin-bot jellyfin-bot removed merge conflict Merge conflicts should be resolved before a merge stale Stale and will be closed if no activity occurs labels Jan 3, 2024
@crobibero crobibero merged commit f49de51 into jellyfin:master Jan 6, 2024
22 of 23 checks passed
@mohd-akram mohd-akram deleted the audio-spatial-format branch January 6, 2024 21:34
skysbird pushed a commit to skysbird/jellyfin that referenced this pull request Feb 3, 2024
* Detect audio spatial format

* Update MediaBrowser.Model/Entities/MediaStream.cs

* Update MediaStream.cs

---------

Co-authored-by: Cody Robibero <cody@robibe.ro>
KrzaQ pushed a commit to KrzaQ/jellyfin that referenced this pull request Feb 13, 2024
* Detect audio spatial format

* Update MediaBrowser.Model/Entities/MediaStream.cs

* Update MediaStream.cs

---------

Co-authored-by: Cody Robibero <cody@robibe.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants