Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

Regex used by grep to determine version fails because it's not BRE #2777

@Gumnos

Description

@Gumnos

The configure.ac file tests the version using non-BRE (Basic Regular Expression) \+ tokens, causing it not to match with OpenBSD's grep. Extracting the relevant log output during the cargo build execution:

5.3.0-1-ge13ca993e8ccb9ba9847cc330696e02839f328f7 does not match <major>.<minor>.<bugfix>-<nrev>-g<gid> or VERSION                                                                                          

The grep needs to use actual BRE (just using the * and doubling up the previous atom to require one or more):

echo "${with_version}" | grep '^[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*-[0-9][0-9]*-g[0-9a-f][0-9a-f]*$'

or (possibly less-portably) you could use -E for Extended Regular Expressions and just + (not \+) such as

echo "${with_version}" | grep -E '^[0-9]+\.[0-9]+\.[0-9]+-[0-9]+-g[0-9a-f]+$'

Originally filed as tikv/jemallocator#112 which caused problems attempting to build yazi but was told to file it here, so here it is ☺

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions