Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement and refactor import component form #126

Merged

Conversation

issambaccouch
Copy link
Contributor

No description provided.

@issambaccouch issambaccouch changed the title Implement and refactor import component form [WIP] Implement and refactor import component form Oct 13, 2023
@issambaccouch issambaccouch marked this pull request as draft October 13, 2023 20:13
@marrouchi marrouchi changed the base branch from jempi-base to JMPI-706-fix-max-size-label-and-datagrid-header-ui-ux October 13, 2023 20:55
@issambaccouch issambaccouch force-pushed the JMPI-707-implement-and-refactor-import-component-form branch from da94118 to 9e185e7 Compare October 17, 2023 10:35
@issambaccouch issambaccouch changed the title [WIP] Implement and refactor import component form Implement and refactor import component form Oct 23, 2023
@issambaccouch issambaccouch marked this pull request as ready for review October 23, 2023 07:51
@issambaccouch issambaccouch changed the base branch from JMPI-706-fix-max-size-label-and-datagrid-header-ui-ux to jembi-base October 23, 2023 15:31
@issambaccouch issambaccouch changed the base branch from jembi-base to jempi-base October 23, 2023 15:33
@walisc
Copy link
Collaborator

walisc commented Oct 24, 2023

Hi @issambaccouch ...done reviewing this (only have the one comment above). Looking very cool thought Issam! Like how dynamic it is .

@issambaccouch issambaccouch changed the base branch from jempi-base to dev October 27, 2023 14:59
@issambaccouch issambaccouch requested review from walisc and removed request for ajinkyagadewar October 27, 2023 15:03
Copy link
Collaborator

@walisc walisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @issambaccouch !

@issambaccouch issambaccouch force-pushed the JMPI-707-implement-and-refactor-import-component-form branch from 0ccda69 to 58b12dd Compare October 27, 2023 15:13
@issambaccouch issambaccouch merged commit bcce41c into dev Oct 27, 2023
@issambaccouch issambaccouch deleted the JMPI-707-implement-and-refactor-import-component-form branch October 27, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants