Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Matching Should Include HTTP Methods #1100

Open
mhawila opened this issue Sep 11, 2020 · 3 comments
Open

Request Matching Should Include HTTP Methods #1100

mhawila opened this issue Sep 11, 2020 · 3 comments

Comments

@mhawila
Copy link
Contributor

mhawila commented Sep 11, 2020

When two channels match the same request the method of the request should also be considered before applying the assigned priorities. For example, If I configure two channels A and B with A having higher priority both matching /foo/bar while allowing GET on A and POST on B, then when an incoming /foo/bar is matched the system should check the HTTP method associated with the the request. In the example above if the method happens to be POST then the request should be routed to channel B. The priority should only be applied when both channels are configured to match the POST request.

@rcrichton
Copy link
Member

Hi, thanks for this. This sounds like a bug that should be resolved. I'l add it to our internal backlog.

mhawila added a commit to mhawila/openhim-core-js that referenced this issue Sep 12, 2020
mhawila added a commit to mhawila/openhim-core-js that referenced this issue Sep 12, 2020
@mhawila
Copy link
Contributor Author

mhawila commented Sep 12, 2020

Pull request

@BMartinos
Copy link
Collaborator

Hi @mhawila Thank you for picking up this bug and also supplying a PR fix for this issue. One of our Team Members will be reviewing this soon.

MattyJ007 added a commit that referenced this issue May 11, 2021
Issue #1100: Request matching should include HTTP methods
MattyJ007 added a commit that referenced this issue May 11, 2021
Revert "Issue #1100: Request matching should include HTTP methods"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants