Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS runner to GitHub Action Workflow #552

Merged
merged 4 commits into from
Jan 16, 2021

Conversation

RJ722
Copy link
Contributor

@RJ722 RJ722 commented Jan 15, 2021

Summary of the changes in this pull request

@jendrikseipp and me discussed setting up an automated release for mac. I want to take it up, but I am still starting out with app development, and have no idea how to create a dmg/pkg file for distribution.

However, as a start, we are planning to test all new pull requests, and setting up nightly builds to run on mac as well.

Pull request checklist

  • I have added an entry in CHANGELOG.md including my name and issue and/or pull request number.
  • If applicable: I have removed the corresponding entry in TODO.md.

@RJ722 RJ722 closed this Jan 15, 2021
@RJ722 RJ722 reopened this Jan 15, 2021
@RJ722
Copy link
Contributor Author

RJ722 commented Jan 15, 2021

Looks like support for macOS Big Sur is still in preview, and the job not starting is a known issue.

I'll go ahead and remove it for now.

@RJ722 RJ722 changed the title Update and rename ubuntu.yml to run-tests.yml Add macOS runner to GitHub Action Workflow Jan 15, 2021
Copy link
Owner

@jendrikseipp jendrikseipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me. I'm surprised that so few changes are necessary for this.

CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/run-tests.yml Outdated Show resolved Hide resolved
@jendrikseipp jendrikseipp marked this pull request as ready for review January 16, 2021 17:27
@jendrikseipp jendrikseipp merged commit 7f50419 into jendrikseipp:master Jan 16, 2021
@jendrikseipp
Copy link
Owner

Thanks, Rahul!

@RJ722 RJ722 deleted the patch-1 branch January 17, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants