-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Terraform azurerm
provider version to 4.5.0
#793
Bump Terraform azurerm
provider version to 4.5.0
#793
Conversation
e64ad6f
to
b21f747
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are deprecated attributes: let's block until we can work on it (ref. https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.114.0)
b21f747
to
17083f6
Compare
updates.jenkins.io.tf
Outdated
capacity = 1 | ||
family = "C" # Basic/Standard SKU family | ||
sku_name = "Standard" # A replicated cache in a two node Primary/Secondary configuration managed by Microsoft, with a high availability SLA. | ||
non_ssl_port_enabled = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weird, this change shows the following plan:
# azurerm_redis_cache.updates_jenkins_io will be updated in-place
~ resource "azurerm_redis_cache" "updates_jenkins_io" {
~ enable_non_ssl_port = true -> false
Gotta check with the upstream provider repo: until then no merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gotta check around the redis part
5d9bb24
to
5b2f3d0
Compare
azurerm
provider version to 3.114.0azurerm
provider version to 3.115.0
70a2cc4
to
fa20b10
Compare
azurerm
provider version to 3.115.0azurerm
provider version to 3.116.0
6ce4dae
to
366297b
Compare
azurerm
provider version to 3.116.0azurerm
provider version to 4.0.0
366297b
to
16cc8d0
Compare
94e987d
to
c63a41e
Compare
azurerm
provider version to 4.2.0azurerm
provider version to 4.3.0
6fa5905
to
6076097
Compare
azurerm
provider version to 4.3.0azurerm
provider version to 4.4.0
e21292e
to
b19219a
Compare
azurerm
provider version to 4.4.0azurerm
provider version to 4.5.0
7dc6f54
to
d6437c2
Compare
Made with ❤️️ by updatecli
d6437c2
to
2acf5be
Compare
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
1 add + 1 create: the provider change makes the data Azure PLS datasource to be re-read, which is seen as a re-creation needed for the Azure private endpoint for mirrorbits CLI on trusted.ci.
=> should be automatic, we'll watch. -
23 changes:
- 1 change is the DNS private record associated to the endpoint recreation
- 20 changes are
cross_tenant_replication_enabled
set tofalse
on the storage accounts - 2 changes are
node_os_upgrade_channel
set to defaultNodeImage
for public and private clusters (not needed for infra.ci and ci.jio cluster as it uses Azure Linux Node Images)
Bump Terraform `azurerm` provider version
Update Terraform lock file
changes detected: "hashicorp/azurerm" updated from "3.113.0" to "4.5.0" in file ".terraform.lock.hcl"
Created automatically by Updatecli
Options:
Most of Updatecli configuration is done via its manifest(s).
Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!