Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Terraform azurerm provider version to 4.5.0 #793

Conversation

jenkins-infra-updatecli[bot]
Copy link
Contributor

@jenkins-infra-updatecli jenkins-infra-updatecli bot commented Aug 1, 2024

Bump Terraform `azurerm` provider version

Update Terraform lock file

changes detected: "hashicorp/azurerm" updated from "3.113.0" to "4.5.0" in file ".terraform.lock.hcl"

Jenkins pipeline link
Updatecli logo

Created automatically by Updatecli

Options:

Most of Updatecli configuration is done via its manifest(s).

  • If you close this pull request, Updatecli will automatically reopen it, the next time it runs.
  • If you close this pull request and delete the base branch, Updatecli will automatically recreate it, erasing all previous commits made.

Feel free to report any issues at github.com/updatecli/updatecli.
If you find this tool useful, do not hesitate to star our GitHub repository as a sign of appreciation, and/or to tell us directly on our chat!

@jenkins-infra-updatecli jenkins-infra-updatecli bot requested a review from a team August 1, 2024 21:29
@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch from e64ad6f to b21f747 Compare August 2, 2024 09:03
@dduportal dduportal self-assigned this Aug 6, 2024
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are deprecated attributes: let's block until we can work on it (ref. https://github.com/hashicorp/terraform-provider-azurerm/releases/tag/v3.114.0)

@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch from b21f747 to 17083f6 Compare August 6, 2024 09:30
capacity = 1
family = "C" # Basic/Standard SKU family
sku_name = "Standard" # A replicated cache in a two node Primary/Secondary configuration managed by Microsoft, with a high availability SLA.
non_ssl_port_enabled = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird, this change shows the following plan:

# azurerm_redis_cache.updates_jenkins_io will be updated in-place
  ~ resource "azurerm_redis_cache" "updates_jenkins_io" {
      ~ enable_non_ssl_port           = true -> false

Gotta check with the upstream provider repo: until then no merge!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotta check around the redis part

@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch 4 times, most recently from 5d9bb24 to 5b2f3d0 Compare August 9, 2024 16:51
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump Terraform azurerm provider version to 3.114.0 Bump Terraform azurerm provider version to 3.115.0 Aug 9, 2024
@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch 5 times, most recently from 70a2cc4 to fa20b10 Compare August 16, 2024 07:21
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump Terraform azurerm provider version to 3.115.0 Bump Terraform azurerm provider version to 3.116.0 Aug 16, 2024
@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch 8 times, most recently from 6ce4dae to 366297b Compare August 23, 2024 07:36
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump Terraform azurerm provider version to 3.116.0 Bump Terraform azurerm provider version to 4.0.0 Aug 23, 2024
@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch from 366297b to 16cc8d0 Compare August 23, 2024 09:02
@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch 3 times, most recently from 94e987d to c63a41e Compare September 20, 2024 11:19
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump Terraform azurerm provider version to 4.2.0 Bump Terraform azurerm provider version to 4.3.0 Sep 20, 2024
@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch 7 times, most recently from 6fa5905 to 6076097 Compare September 25, 2024 09:43
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump Terraform azurerm provider version to 4.3.0 Bump Terraform azurerm provider version to 4.4.0 Oct 4, 2024
@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch from e21292e to b19219a Compare October 11, 2024 12:25
@jenkins-infra-updatecli jenkins-infra-updatecli bot changed the title Bump Terraform azurerm provider version to 4.4.0 Bump Terraform azurerm provider version to 4.5.0 Oct 11, 2024
@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch 8 times, most recently from 7dc6f54 to d6437c2 Compare October 15, 2024 15:44
Made with ❤️️ by updatecli
@jenkins-infra-updatecli jenkins-infra-updatecli bot force-pushed the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch from d6437c2 to 2acf5be Compare October 16, 2024 16:26
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Signed-off-by: Damien Duportal <damien.duportal@gmail.com>
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 1 add + 1 create: the provider change makes the data Azure PLS datasource to be re-read, which is seen as a re-creation needed for the Azure private endpoint for mirrorbits CLI on trusted.ci.
    => should be automatic, we'll watch.

  • 23 changes:

    • 1 change is the DNS private record associated to the endpoint recreation
    • 20 changes are cross_tenant_replication_enabled set to false on the storage accounts
    • 2 changes are node_os_upgrade_channel set to default NodeImage for public and private clusters (not needed for infra.ci and ci.jio cluster as it uses Azure Linux Node Images)

@dduportal dduportal merged commit 459c627 into main Oct 16, 2024
2 checks passed
@dduportal dduportal deleted the updatecli_main_f410411e63aff4bb73a81c2aec1d373cf8a903e63b30dee2006b0030d8a94cc8 branch October 16, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants