Update dependencies #2423
Merged
Update dependencies #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed; the context from the latest run is: Expand to view |
|
Probably it's time to enable Dependabot here |
|
Build failed; the context from the latest run is: Expand to view |
|
@oleg-nenashev good idea. This PR requires switching to alpha release, which is something dependabot should not suggest.(It will take a while to release awestruct stable and some of the recent changes in awestruct were done for Jenkins specifically, so I would suggest to use alpha rather than wait for a stable release) |
|
Build failed; the context from the latest run is: Expand to view |
|
Build failed; the context from the latest run is: Expand to view |
oleg-nenashev
approved these changes
Aug 27, 2019
| @@ -5,7 +5,6 @@ google_analytics: | |||
| anonymizeIp: true | |||
| account: UA-4216293-5 | |||
| haml: | |||
| :ugly: true | |||
There was a problem hiding this comment.
The option was removed in haml/haml#894
|
@zbynek Can you run |
|
@bitwiseman I uploaded the result of |
|
@zbynek |
|
@bitwiseman links are fixed now in the demo page. |
|
Build failed; the context from the latest run is: Expand to view |
|
restart.... |
bitwiseman
approved these changes
Sep 9, 2019
|
🚢 🇮🇹 ? Or do we want to get more feedback? |
|
Ship it
…On Mon, Sep 9, 2019, 1:12 AM Oleg Nenashev ***@***.***> wrote:
🚢 🇮🇹 ? Or do we want to get more feedback?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2423?email_source=notifications&email_token=AABGIDNT6YNAC6TGXX4ORETQIXZNLA5CNFSM4INBK34KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6GPCMI#issuecomment-529330481>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABGIDINNWKKP7GIWLGZB7TQIXZNLANCNFSM4INBK34A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix https://issues.jenkins-ci.org/browse/WEBSITE-469
Also fixes https://issues.jenkins-ci.org/browse/WEBSITE-523 (the issue is "done" but the website was not updated to use the fixed version of the extension library) and brings minor improvements for local development (haml 5 is needed to avoid generating bogus error messages, some of the awestruct fixes relate to logging, see https://github.com/awestruct/awestruct/releases )