commons-digester:2.1 removal #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First shot, refining
timja
reviewed
Jun 3, 2021
MRamonLeon
reviewed
Jun 3, 2021
zbynek
reviewed
Jun 3, 2021
jtnord
reviewed
Jun 3, 2021
thanks @zbynek! Co-authored-by: Zbynek Konecny <zbynek1729@gmail.com>
Thanks @jtnord
Thanks @jlamasrios !
|
I think I have addressed all the feedback. This is ready for review and possibly merge to me @jenkins-infra/copy-editors Thanks all. |
timja
approved these changes
Jun 4, 2021
|
|
||
| === Resources | ||
|
|
||
| link:https://github.com/jenkinsci/jenkins/pull/5320[PR-5320]:: removing `commons-digester:2.1`. |
There was a problem hiding this comment.
a screenshot of the post in the description would be good to include to make sure all this renders correctly
There was a problem hiding this comment.
Care to elaborate? I'm confused by this request.
There was a problem hiding this comment.
normally someone would take a full page screenshot of a post and put it in the description so others don't have to check it out locally.
There was a problem hiding this comment.
oh ok, I generally don't do that for simple entries with text, sticking with GH renderer. Looking into this then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blog entry provides a heads-up on the Core PR that has been merged this morning, we should publish this soon enough.
jenkinsci/jenkins#5320