Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noting changes towards 2.50 #725

Merged
merged 2 commits into from
Mar 10, 2017

Conversation

Copy link
Contributor

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and detailed changelog!

pull: 2765
- type: rfe
message: >
API: Allow providing a custom task name in Run/Schedule UI via the <code>AlternativeUiTextProvider</code> extension.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API is ambiguous, there's also the (user) remote API

@@ -87,7 +87,81 @@
date: 2017-03-11
changes:
- type: rfe
message: Expose the noun for an item when behaving as a task via <tt>AlternativeUiTextProvider</tt>.
message: >
Allow searching by build param values in the Build history widget.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercase build, write parameter instead of param

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or "Build History widget"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either works. Not sure how we're usually using it.

@oleg-nenashev
Copy link
Contributor Author

It will collide with #739

@@ -87,7 +87,82 @@
date: 2017-03-11
changes:
- type: rfe
message: Expose the noun for an item when behaving as a task via <tt>AlternativeUiTextProvider</tt>.
message: >
Allow searching by build parameter values in the <code>Build History</code> widget.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should reserve code formatting for things that are technical in nature, e.g. Method names, class names, file names, etc.

I don't think this needs any special formatting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tt then?
For technical things we may also want to introduce the Javadoc macro in yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleg-nenashev Both are inappropriate IMO. em, strong if you need to emphasize something. But neither this nor the versions below qualify.

pull: 2780
- type: bug
message: >
Update Remoting from <code>3.5</code> to <code>3.7</code>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@rtyler rtyler merged commit 892f925 into jenkins-infra:master Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants