Refresh the design of the 'Changelogs' pages #7479
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,42 @@ | ||
| --- | ||
| layout: simplepage | ||
| title: Changelog | ||
| notitle: true | ||
| tight: true | ||
| backlink: | ||
| label: Back to changelogs | ||
| url: ../ | ||
| --- | ||
|
|
||
| = partial('release-header.html.haml', :release => page.release, :entry => true) | ||
|
|
||
| - if page.type == 'stable' | ||
| %a{:class => "app-button app-button--primary app-releases__upgrade-guide", :href => "/doc/upgrade-guide/" + page.release.version.rpartition('.').first + "#upgrading-to-jenkins-lts-" + page.release.version.to_s.tr_s(".", "-")} | ||
| %ion-icon{:name => "arrow-up-circle-outline"} | ||
| .app-releases__upgrade-guide__title | ||
| Looking to upgrade? | ||
| .app-releases__upgrade-guide__description | ||
| = "Check the Upgrade Guide for assistance" | ||
|
|
||
| #head | ||
| %script{:src => "/files/rate.js", :type => "text/javascript"} | ||
|
|
||
| :javascript | ||
| $(document).ready(function() { | ||
| loaddata(this); | ||
| }); | ||
|
|
||
| - if page.release.changes and page.release.lts_changes and page.release.lts_baseline | ||
| .app-releases__notable-changes | ||
| -# TODO figure out how to get rid of this | ||
| = "Changes since #{page.release.lts_baseline}" | ||
|
|
||
| %div.app-releases__list__items | ||
| = partial('changelog-changes.html.haml', :changes => page.release.changes) | ||
|
|
||
| - if page.release.changes and page.release.lts_changes | ||
| .app-releases__notable-changes | ||
| = "Notable changes since #{page.release.lts_predecessor}" | ||
|
|
||
| %div.app-releases__list__items | ||
| = partial('changelog-changes.html.haml', :changes => page.release.lts_changes) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,36 +1,42 @@ | ||
| :ruby | ||
| tags = { | ||
| 'security' => 'Security', | ||
| 'rfe' => 'Enhancement', | ||
| 'majorrfe' => 'Major enhancement', | ||
| 'bug' => 'Bug fix', | ||
| 'majorbug' => 'Major bug fix' | ||
| } | ||
|
|
||
| - if page.changes.empty? | ||
| %em | ||
| No notable changes in this release. | ||
| - page.changes.group_by { |message| message["type"] }.each do | type, logs | | ||
| %div{:class => 'app-releases__tag app-releases__tag--' + type.gsub(' ', '')} | ||
| = tags[type.gsub(' ', '')] | ||
| %ul.app-releases__list{:class => 'app-releases__list--' + type.gsub(' ', '')} | ||
| - logs.each do | change | | ||
| %li | ||
| = change.message | ||
| %span.app-releases__references | ||
| - if change.references | ||
| - change.references.each_with_index do | reference, index | | ||
| - if index != 0 | ||
| , | ||
| - if reference.issue | ||
| %a{:href => "https://issues.jenkins.io/browse/JENKINS-#{reference.issue}" }<> | ||
| = "issue #{reference.issue}" | ||
| - if reference.pull | ||
| %a{:href => "https://github.com/jenkinsci/jenkins/pull/#{reference.pull}" }<> | ||
| = "pull #{reference.pull}" | ||
| - else | ||
| %a{:href => reference.url }<> | ||
| - if reference.title | ||
| = reference.title | ||
| - else | ||
| = reference.url | ||
| - elsif change.issue | ||
| %a{:href => "https://issues.jenkins.io/browse/JENKINS-#{change.issue}" }<> | ||
| = "issue #{change.issue}" | ||
| - elsif change.pull | ||
| %a{:href => "https://github.com/jenkinsci/jenkins/pull/#{change.pull}" }<> | ||
| = "pull #{change.pull}" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,16 @@ | ||
| %div.app-releases__list__header | ||
| %div | ||
| - if page.entry | ||
| %h1{:id => "v#{page.release.version}", :class => 'app-releases__item__title', :'data-type' => 'release-header', :'data-version' => page.release.version} | ||
| = 'Changelog for ' + page.release.version | ||
| - else | ||
| %h3{:id => "v#{page.release.version}", :class => 'app-releases__item__title', :'data-type' => 'release-header', :'data-version' => page.release.version} | ||
| %a{:href => "/#{page.url}/#{page.release.version}/"} | ||
| = page.release.version | ||
| - if page.release.date | ||
| %div{:class => 'app-releases__item__date'} | ||
| = page.release.date.strftime('%B %-d, %Y') | ||
|
|
||
| - if page.release.banner | ||
| %div{:class => 'app-banner'} | ||
| = page.release.banner |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,40 +3,30 @@ layout: changelog | |
| title: LTS Changelog | ||
| show_ratings: true | ||
| has_rss: true | ||
| actions: | ||
| <a class="app-button app-button--primary app-mobile-hide" href="/doc/upgrade-guide"> | ||
| <ion-icon name="arrow-up-circle-outline"></ion-icon> | ||
| Upgrade Guide | ||
| </a> | ||
| --- | ||
|
|
||
| .ratings | ||
| - # source: https://github.com/jenkins-infra/jenkins.io/blob/master/content/_data/changelogs/lts.yml | ||
| - site.changelogs[:lts].reverse_each do | release | | ||
| - if Gem::Version.new(release.version) <= Gem::Version.new(site.jenkins.stable) | ||
| %div | ||
|
There was a problem hiding this comment. If you go back to 
There was a problem hiding this comment.
That's from the HTML archive, when we didn't use YAML yet: I think this difference is acceptable and we don't need to rewrite ancient HTML for the new format. It seems that all we're losing with this PR is the old changelog votes for 2.19.4 and earlier, that seems OK. (For weekly changelog, we didn't have votes in changelog-old already anyway.) There was a problem hiding this comment. Do we need to keep displaying it on the page or could we archive it? There was a problem hiding this comment. I don't think we should delete changelogs, but if we do, we should start with historical weekly changelogs. There was a problem hiding this comment. Weekly only displays x number already, The oldest one is: (29 weeks) Not saying delete them, we could have an archive page for older than a reasonable period. There was a problem hiding this comment. Makes sense, I read your suggestion as completely removing. I'd keep at least 2 years of changelogs around though for LTS. |
||
| = partial('release-header.html.haml', :release => release, :url => 'changelog-stable') | ||
| - if release.changes and release.lts_changes and release.lts_baseline | ||
| .app-releases__notable-changes{:style => "margin-top: 15px"} | ||
| -# TODO figure out how to get rid of this | ||
| = "Changes since #{release.lts_baseline}" | ||
| %div.app-releases__list__items | ||
| = partial('changelog-changes.html.haml', :changes => release.changes) | ||
|
|
||
| - if release.changes and release.lts_changes | ||
| .app-releases__notable-changes | ||
| = "Notable changes since #{release.lts_predecessor}" | ||
| %div.app-releases__list__items | ||
| = partial('changelog-changes.html.haml', :changes => release.lts_changes) | ||
|
Comment on lines
+26
to
+30
There was a problem hiding this comment. This is not indented far enough, so https://www.jenkins.io/changelog-stable/ currently has "Notable changes" for an unreleased version of Jenkins. |
||
|
|
||
| = partial('changelog-stable.html') | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend that at least the same grouping be done for the RSS/Atom changelog feed. I do not expect changelog authors to regularly look at that, so will likely miss if the experience there deteriorates (less grouping of entries in the data file).