Update dependency org.jsoup:jsoup to v1.15.3 [SECURITY] #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.10.3
->1.15.3
GitHub Vulnerability Alerts
CVE-2021-37714
Impact
What kind of vulnerability is it? Who is impacted?
Those using jsoup to parse untrusted HTML or XML may be vulnerable to DOS attacks. If the parser is run on user supplied input, an attacker may supply content that causes the parser to get stuck (loop indefinitely until cancelled), to complete more slowly than usual, or to throw an unexpected exception. This effect may support a denial of service attack.
Patches
Has the problem been patched? What versions should users upgrade to?
Users should upgrade to jsoup 1.14.2
Workarounds
Is there a way for users to fix or remediate the vulnerability without upgrading?
Users may rate limit input parsing. Users should limit the size of inputs based on system resources. Users should implement thread watchdogs to cap and timeout parse runtimes.
CVE-2022-36033
jsoup may incorrectly sanitize HTML including
javascript:
URL expressions, which could allow cross-site scripting (XSS) attacks when a reader subsequently clicks that link. If the non-defaultSafeList.preserveRelativeLinks
option is enabled, HTML includingjavascript:
URLs that have been crafted with control characters will not be sanitized. If the site that this HTML is published on does not set a Content Security Policy, an XSS attack is then possible.Impact
Sites that accept input HTML from users and use jsoup to sanitize that HTML, may be vulnerable to cross-site scripting (XSS) attacks, if they have enabled
SafeList.preserveRelativeLinks
and do not set an appropriate Content Security Policy.Patches
This issue is patched in jsoup 1.15.3.
Users should upgrade to this version. Additionally, as the unsanitized input may have been persisted, old content should be cleaned again using the updated version.
Workarounds
To remediate this issue without immediately upgrading:
SafeList.preserveRelativeLinks
, which will rewrite input URLs as absolute URLsBackground and root cause
jsoup includes a Cleaner component, which is designed to sanitize input HTML against configurable safe-lists of acceptable tags, attributes, and attribute values.
This includes removing potentially malicious attributes such as
<a href="javascript:...">
, which may enable XSS attacks. It does this by validating URL attributes against allowed URL protocols (e.g.http
,https
).However, an attacker may be able to bypass this check by embedding control characters into the href attribute value. This causes the Java URL class, which is used to resolve relative URLs to absolute URLs before checking the URL's protocol, to treat the URL as a relative URL. It is then resolved into an absolute URL with the configured base URI.
For example,
java\tscript:...
would resolve tohttps://example.com/java\tscript:...
.By default, when using a safe-list that allows
a
tags, jsoup will rewrite any relative URLs (e.g./foo/
) to an absolute URL (e.g.https://example.com/foo/
). Therefore, this attack attempt would be successfully mitigated. However, if the option SafeList.preserveRelativeLinks is enabled (which does not rewrite relative links to absolute), the input is left as-is.While Java will treat a path like
java\tscript:
as a relative path, as it does not match the allowed characters of a URL spec, browsers may normalize out the control characters, and subsequently evaluate it as ajavascript:
spec inline expression. That disparity then leads to an XSS opportunity.Sites defining a Content Security Policy that does not allow javascript expressions in link URLs will not be impacted, as the policy will prevent the script's execution.
For more information
If you have any questions or comments about this advisory:
Credits
Thanks to Jens Häderer, who reported this issue, and contributed to its resolution.
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.