Replace klakegg containers with floryn90 containers #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The floryn90 containers have been forked from the klakegg containers and are more actively maintained.
klakegg/docker-hugo#82 notes that root is the default user of the container, but that causes issues for our environment because it blocks git operations. Switch to run as the current user so that git operations are not blocked. Running as the current user means that the Hugo build lock cannot be written. Disable it with a command line switch. Not a perfect solution, but simple enough to allow upgrade to a more recent Hugo version.
This was referenced Dec 29, 2023
dduportal
reviewed
Jan 3, 2024
docker-compose.yaml
Outdated
| image: klakegg/hugo:0.95.0-ext-asciidoctor | ||
| # "ext-" for the Hugo extended edition including git (https://github.com/floryn90/docker-hugo/blob/master/README.md#hugo-extended-edition) | ||
| user: ${RUN_AS_USER} | ||
| image: floryn90/hugo:0.121.1-ext-asciidoctor |
There was a problem hiding this comment.
Alas there are no linux/arm64 for this image's tag: https://hub.docker.com/layers/floryn90/hugo/ext-asciidoctor-onbuild/images/sha256-222d38bf30305cd91eb9badee59b7156ac6fff14cb331393993f463155eda0c8?context=explore
which excludes any macOS user
|
For information: since https://github.com/asciidoctor/docker-asciidoctor/releases/tag/1.63.0 (a few days ago), the |
|
For information, I'm gonna open another PR using https://docker.hugomods.com/docs/introduction/ instead of this one. Stay tuned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace klakegg containers with floryn90 containers
The container images we have used are no longer maintained (as evidence by outdated versions and no responses to issue reports). This switches to a fork of the original repository based on a comment in one of the issues in the original repository. The fork is being maintained and is kept current with Hugo releases. It does not yet publish a GitHub action, so it is not yet a complete replacement for the klakegg repository.
Upgrades to the most recent Hugo release and adapts the build process to the newest release of command line git.
Known issues with this pull request
This pull request does not update the GitHub action to a newer version because the action is not available from the floryn90 fork. It only updates the configuration in the Docker compose definition.