[INFRA-2513] - Update allowed-labels.properties

[jtnord]

do not allow a slave label

someone with access to all infra could find/replace this label with agent if they where so inclined.

[oleg-nenashev]

@jtnord Although it is technically correct, we need to do some cleanup and in https://github.com/jenkins-infra/update-center2/blob/master/src/main/resources/label-definitions.properties first. I'd guess replacing all labels by agent is a best step.

If you update the Label definitions file, I will get GitHub repos fixed

[oleg-nenashev]

If we take agents or something similar as a new label, again I will do the GitHub legwork. Created https://issues.jenkins-ci.org/browse/INFRA-2513 as a placeholder

[jtnord]

changed all to agent in the properties file. looks a little strange as the prior label was pluralised (slaves) and now it is not (agent) but other things are singular (report vs reports / parameter vs parameters)

[daniel-beck]

We should amend https://github.com/jenkinsci/jenkins/blob/9ead76e210a52cda65befe89e70355127ad3ff31/core/src/main/resources/hudson/model/Messages.properties#L325 first to support the replacement, and backport the change into LTS, otherwise the display of this label in Jenkins will suffer quite a bit, especially since jenkinsci/jenkins#4534

Likewise, https://github.com/jenkins-infra/plugin-site-api/blob/bd2a5fe337ddf9526666ef5a7ad6a3f5bb388c6f/src/main/resources/categories.json#L34 and https://github.com/jenkins-infra/plugin-site-api/blob/bd2a5fe337ddf9526666ef5a7ad6a3f5bb388c6f/src/main/resources/labels.json#L35-L36

[daniel-beck]

@jtnord Are you still interested in this change?

[jtnord]

@jtnord Are you still interested in this change?

I do not know enough about the UC to know what needs changing and where to move this forward.

This was an attempt to keep aligning things better given the project decided to move to agents.

[oleg-nenashev]

If you are fine @daniel-beck @jtnord , I would like to keep it open. I want to deliver an engine for label aliases, and I will do it on the top of this PR

[daniel-beck]

Works for me.

[oleg-nenashev]

I will be unable to work on a new engine anytime soon. It would be needed for removing "slave" terms from labels and Artifact IDs. Maybe @MarkEWaite or @markyjackson-taulia would be interested to facilitate this change in the community

[markjacksonfishing]

I can work on this. I will sync with you @oleg-nenashev

[daniel-beck]

and Artifact IDs

That's quite some scope creep here.