Remove wiki urls by rewriting them to github blobs #548
Conversation
|
Thanks! Are there plans to create the pages that are currently missing? These are the URLs in that repo that don't exist, introduced by this change: |
daniel-beck
added
the
enhancement
|
No concrete plans. Those are very hard to find. Web archive doesn't either http://web.archive.org/web/*/https://wiki.jenkins-ci.org/display/JENKINS/Aqua+MicroScanner+Plugin So each of those 2 dozen plugins would have to have a lot of manual digging around, and since they didn't work before, i'm not really concerned about this breaking things. |
|
@halkeye @daniel-beck should we add an override for those to point to their GitHub repo? That can't make things worse... 🤷 I can create a follow-up PR for that. |
|
I originally pulled the list exported by update center, so if they pointed to the right place I grabbed them - https://github.com/jenkins-infra/plugins-wiki-docs/blob/master/export.js#L39
🤦 I just realized as I was clicking around, https://github.com/jenkinsci/aqua-microscanner-plugin has a readme. I think the overrides are a good idea |
|
@zbynek Ideally we'd file PRs first for such plugins, at least the ones somewhat actively maintained. Overrides are useful in the short term, but carrying them indefinitely is something we should try to not do. |
|
@halkeye Can you access wiki page rename information, or is that something the exporter already supported? Or do we have a list of all wiki pages to look through for typo'ed / similarly named pages? (Obviously the ROI here is quickly reached, so we shouldn't overdo it with the manual work.) Affected plugins by popularity |
|
PR for h2-api was merged jenkinsci/h2-api-plugin#2 by @cyrille-leclerc, pipeliine-timeline was updated here jenkinsci/pipeline-timeline-plugin@74bd51e, pipeline-restful-api here jenkinsci/pipeline-restful-api-plugin@ed72eaa -- none of them released |
I have access to an offline copy and db dump. Its very slow. Lots of pages don't work cause of hostname rename (localhost vs wiki.jenkins). I'll admit after 3 years to fix it, these are all ones that didn't bother to do it. I won't shed a tear if they stay broken. I can try and figure out more when I get back from giving blood. I'll probably import the sql into my homelab and see what i can't find out from raw sql |
|
No, just waiting for me to have some time, no later than the weekend, probably earlier. How does this currently impact users? Since the site special-cases this already, I didn't get the impression this was urgent. |
|
Nope. Plugin site has already been patched, I thought I was the blocker so wanted to check in before i archived the email |
| url = url.replace("http://wiki.jenkins-ci.org", "https://wiki.jenkins.io"); | ||
| url = url.replace("https://wiki.jenkins-ci.org", "https://wiki.jenkins.io"); |
There was a problem hiding this comment.
url = url.replace("http://wiki.jenkins-ci.org", "https://wiki.jenkins.io");
->
url = url.replaceAll("(http|https)://wiki.jenkins-ci.org", "https://wiki.jenkins.io");
| if (url.startsWith("https://wiki.jenkins.io")) { | ||
| url = "https://github.com/jenkins-infra/plugins-wiki-docs/blob/master/" + artifact.artifactId + "/README.md"; | ||
| } |
There was a problem hiding this comment.
| if (url.startsWith("https://wiki.jenkins.io")) { | |
| url = "https://github.com/jenkins-infra/plugins-wiki-docs/blob/master/" + artifact.artifactId + "/README.md"; | |
| } |
Since this PR the wiki service has been restored, no need to redirect to github blobs.
|
Per @lemeurherve's comment, this no longer seems necessary or useful. |
cc @daniel-beck @zbynek