Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct Git Server URL and auth details for lighthouse as for scm provider #459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cameronbraid
Copy link
Contributor

This fixes it for me when using gitea, not sure if this is the proper way to fix it. It just re-uses the same git url and auth details as the scm provider uses

fixes #424

@jenkins-x-bot
Copy link
Contributor

Hi @cameronbraid. Thanks for your PR.

I'm waiting for a jenkins-x-plugins or todo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign ankitm123
You can assign the PR to them by writing /assign @ankitm123 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@cameronbraid cameronbraid changed the title fix: use currect Git Server URL and auth details for lighthouse as for scm provider fix: use correct Git Server URL and auth details for lighthouse as for scm provider Apr 30, 2022
@ankitm123
Copy link
Contributor

Going to review it tonight ...

@ankitm123
Copy link
Contributor

/ok-to-test

@ankitm123
Copy link
Contributor

can u rebase with the latest master, we have codeql alerts set up now ...

@jenkins-x-bot
Copy link
Contributor

@cameronbraid: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
lint 43359fb link /test lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here.

@ankitm123
Copy link
Contributor

ankitm123 commented May 4, 2022

Linting fails:

pkg/cmd/start/start.go:451:17: Error return value of `o.FindGitToken` is not checked (errcheck)

Run locally make lint with golang-ci lint 1.42.1 (the latest - 1.45.X will give much more errors, we will update it soon)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jx pipeline start asks for GitHub credentials when used with GitLab
3 participants