-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: start migration to eso #397
base: main
Are you sure you want to change the base?
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Quality Gate passedIssues Measures |
/cc @msvticket |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Skisocks The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'll have a first look now and will continue next week. I'll begin with firing a question: How have you tested this so far? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ModifyYAML in convert.go needs to be changed since the schema has changed.
Compare https://github.com/external-secrets/kubernetes-external-secrets/blob/master/charts/kubernetes-external-secrets/crds/kubernetes-client.io_externalsecrets_crd.yaml with https://github.com/external-secrets/external-secrets/blob/main/config/crds/bases/external-secrets.io_externalsecrets.yaml.
https://github.com/external-secrets/kes-to-eso/blob/main/pkg/parser/parser.go could serve as inspiration.
To get the schema right it might be easiest to import github.com/external-secrets/external-secrets/apis/externalsecrets/v1beta1 and use the structures defined in https://github.com/external-secrets/external-secrets/blob/main/apis/externalsecrets/v1beta1/externalsecret_types.go |
Removing backwards compatability, as we'll promote this change with the ESO migration