Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to be able to modify the commit messages for all jx commands that create commits #4782

Closed
1 of 2 tasks
rcarson opened this issue Jul 18, 2019 · 5 comments
Closed
1 of 2 tasks
Labels
area/git area/jenkins area/jenkins indicates the bug was reported against the "Classic Jenkins" installation type kind/enhancement An enhancement of an existing feature lifecycle/rotten priority/important-longterm

Comments

@rcarson
Copy link

rcarson commented Jul 18, 2019

Summary

Internally our on-premise bitbucket server requires a specific commit message format. This causes a problem for any commands that do a commit as part of the steps it performs.

Steps to reproduce the behavior

Setup a commit checker with a regex that is similiar to this: \[.*\].{30}.*

Here is the commit message criteria:

  1. Identification number(s) (Rally, QC, iTrack, PRISM project #, etc.) enclosed in brackets [ ] on the first part of the commit message
  2. Indicate release date, if applicable, and provide additional description
  3. Full comment should be 30 characters or longer, not including identification number(s)
  4. Should not contain more than 6 consecutive repetitive characters
  5. Must contain at least 1 letter: a-z or A-Z

Expected behavior

I would expect that for any command or step that does a commit, that I could modify that commit message or provide a template for the commit message.

Actual behavior

Commands like jx create enviornment do not allow me to modify the commit message.

Jx version

The output of jx version is:

NAME               VERSION
jx                 2.0.480
jenkins x platform 2.0.822
Kubernetes cluster v1.13.5
kubectl            v1.13.6
helm client        Client: v2.12.0+gd325d2a
git                git version 2.15.1
Operating System   Red Hat Enterprise Linux Server release 7.6 (Maipo)

Jenkins type

  • Serverless Jenkins X Pipelines (Tekton + Prow)
  • Classic Jenkins

Kubernetes cluster

Local kubernetes cluster provided by a separate team internally. I have no insight into how it was created.

Operating system / Environment

Linux xxxxxxxxx 3.10.0-957.10.1.el7.x86_64 #1 SMP Thu Feb 7 07:12:53 XXX 2019 x86_64 x86_64 x86_64 GNU/Linux

@abayer abayer added area/git kind/enhancement An enhancement of an existing feature priority/backlog labels Jul 25, 2019
@deanesmith
Copy link
Contributor

/area jenkins

@jenkins-x-bot jenkins-x-bot added the area/jenkins area/jenkins indicates the bug was reported against the "Classic Jenkins" installation type label Jul 26, 2019
@jenkins-x-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle stale

@jenkins-x-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://jenkins-x.io/community.
/lifecycle rotten

@jenkins-x-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

@jenkins-x-bot
Copy link
Contributor

@jenkins-x-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://jenkins-x.io/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git area/jenkins area/jenkins indicates the bug was reported against the "Classic Jenkins" installation type kind/enhancement An enhancement of an existing feature lifecycle/rotten priority/important-longterm
Projects
None yet
Development

No branches or pull requests

5 participants