fix: default to use a temporary directory for applying helm charts #4384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes jenkins-x#4383 Signed-off-by: James Strachan <james.strachan@gmail.com>
Signed-off-by: James Strachan <james.strachan@gmail.com>
|
/test bdd |
Codecov Report
@@ Coverage Diff @@
## master #4384 +/- ##
==========================================
- Coverage 43.36% 43.35% -0.01%
==========================================
Files 810 810
Lines 101180 101199 +19
==========================================
+ Hits 43874 43875 +1
- Misses 53644 53659 +15
- Partials 3662 3665 +3
Continue to review full report at Codecov.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmuir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
daveconde
pushed a commit
to daveconde/jx
that referenced
this pull request
Apr 7, 2020
…enkins-x#4384) * fix: default to use a temporary directory for applying helm charts fixes jenkins-x#4383 Signed-off-by: James Strachan <james.strachan@gmail.com> * fix: lets use https for spring boot model Signed-off-by: James Strachan <james.strachan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4383
Signed-off-by: James Strachan james.strachan@gmail.com