refactor: use google uuid package for generating uuids in the codebase #7455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitm123
force-pushed
the
jx-7454
branch
2 times, most recently
from
9cdbdf6 to
bf674b8
Compare
|
/test unit |
Signed-off-by: ankitm123 <ankitmohapatra123@gmail.com>
|
/assign @garethjevans @abayer |
| @@ -3,8 +3,12 @@ linters-settings: | |||
| list-type: blacklist | |||
| packages: | |||
| - github.com/jenkins-x/jx/v2/pkg/log/ | |||
| - github.com/satori/go.uuid | |||
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: garethjevans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ankitm123 ankitmohapatra123@gmail.com
Submitter checklist
Special notes for the reviewer(s)
Also removed
downloadFilefunction, as it was not being used anywhere. It's not an exported function, so safe to remove imo.Which issue this PR fixes
fixes #7454