Add continuous delivery action template #48
Conversation
|
Is this something that makes sense hosted in jenkins-infra? Seems weird that it says "By timja-org". |
Correct I tested it in my org, it's just your organisation name It can't be in jenkins-infra as it's a template for this org |
workflow-templates/cd.yaml
Outdated
| @@ -0,0 +1,58 @@ | |||
| # Note: additional setup is required, see https://github.com/jenkinsci/incrementals-tools#automatic-deployment | |||
There was a problem hiding this comment.
This is the part I have reservations about: using the template might mislead you into thinking you do not need to do anything else, when you need to
- patch RPU
- edit your
pom.xmlandmaven.config - understand what you are getting into
I wonder if we can add some lightweight action that does a sanity check on config? If your secret is not configured, or if the repo metadata files (perhaps as retrieved by gh REST to avoid a slower full clone) do not meet the requirements, fail quickly with a helpful message.
There was a problem hiding this comment.
probably could be added later, the point of the comment was to point people towards the extra setup.
I would expect this to be added to the archetypes at some point and maybe to @halkeye 's plugins self service app for a one click enable:
| validate: | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| should_release: ${{ steps.verify-ci-status.outputs.result == 'success' && steps.interesting-categories.outputs.interesting == 'true' }} |
There was a problem hiding this comment.
This kind of nonsense is why we created Pipeline. 😁
workflow-templates/cd.yaml
Outdated
| with: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }} | ||
| MAVEN_TOKEN: ${{ secrets.MAVEN_TOKEN }} |
Maybe we can block this from the UC? In that case we would just verify that releases are making it into Artifactory and trust that the rest works normally. |
|
Oh and BTW please https://github.com/jenkinsci/jep/edit/master/jep/229/README.adoc with any changes you make. |
That plugin is for testing the infra end 2 end. Not just CD. It needs to end up in the UC |
Can you see anything that needs changing? I can't see anything there that needs it, this is all implementation detail as far as I can see. (for others this is just changing it from failing builds that don't meet the condition to skipping them, so that actions aren't full of failed builds) relates to jenkins-infra/jenkins-maven-cd-action#5 |
Did not check specifics, but there are various links to examples of a flow which should likely be updated to reflect the newer logic. |
|
jenkinsci/jep#350 needs this to shipped first, can someone 🚢 |
|
Not me. @jenkinsci/jep-editors? |
|
@jenkinsci/github-admins merge here |
@jglick
@garethjevans
@jenkinsci/github-admins
I plan to update incremental-tools to point to this action instead, of inlining it to the README.md
This will be features at the top on the new Actions page in every repo in this organisation with a pom.xml at the root.
The action itself was tested in https://github.com/jenkinsci/jenkins-infra-test-plugin/
anyone is welcome to add themselves for commit access to play around.