Remove concatenation with empty string

jenkinsci · Sep 6, 2024 · ea29ef4 · ea29ef4
1 parent c261c9c
commit ea29ef4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/main/java/org/jenkinsci/test/acceptance/po/Control.java b/src/main/java/org/jenkinsci/test/acceptance/po/Control.java
@@ -222,7 +222,7 @@ protected WebElement find(String caption) {
                 // With enough implementations registered the one we are looking for might
                 // require scrolling in menu to become visible. This dirty hack stretch
                 // yui menu so that all the items are visible.
-                executeScript("" + "YAHOO.util.Dom.batch("
+                executeScript("YAHOO.util.Dom.batch("
                         + "    document.querySelector('.yui-menu-body-scrolled'),"
                         + "    function (el) {"
                         + "        el.style.height = 'auto';"
@@ -253,7 +253,7 @@ protected WebElement find(String caption) {
             // With enough implementations registered the one we are looking for might
             // require scrolling in menu to become visible. This dirty hack stretch
             // yui menu so that all the items are visible.
-            executeScript("" + "YAHOO.util.Dom.batch("
+            executeScript("YAHOO.util.Dom.batch("
                     + "    document.querySelector('.yui-menu-body-scrolled'),"
                     + "    function (el) {"
                     + "        el.style.height = 'auto';"

diff --git a/src/test/java/plugins/DisplayUrlApiTest.java b/src/test/java/plugins/DisplayUrlApiTest.java
@@ -136,7 +136,7 @@ private void doTestRedirects() throws IOException {
 
     private String[] getURLS(String jobName) {
         return jenkins.runScript(
-                        "" + "import org.jenkinsci.plugins.displayurlapi.DisplayURLProvider\n"
+                        "import org.jenkinsci.plugins.displayurlapi.DisplayURLProvider\n"
                                 + "import org.jenkinsci.plugins.workflow.job.*\n"
                                 + "\n"
                                 + "WorkflowJob p = new WorkflowJob(Jenkins.getInstance(),\"%s\");\n"

diff --git a/src/test/java/plugins/ExternalWorkspaceManagerPluginTest.java b/src/test/java/plugins/ExternalWorkspaceManagerPluginTest.java
@@ -107,7 +107,7 @@ public void shareWorkspaceTwoJobsTwoNodes() {
         verifyExternalWorkspacesAction(upstreamJob.name, upstreamBuild);
 
         WorkflowJob downstreamJob = createWorkflowJob(String.format(
-                "" + "def run = selectRun '%s' \n"
+                "def run = selectRun '%s' \n"
                         + "def extWorkspace = exwsAllocate selectedRun: run \n"
                         + "node ('test') { \n"
                         + "   exws (extWorkspace) { \n"
@@ -129,7 +129,7 @@ public void shareWorkspaceTwoJobsTwoNodes() {
     @Test
     public void externalWorkspaceCleanup() {
         WorkflowJob job = createWorkflowJob(String.format(
-                "" + "def extWorkspace = exwsAllocate '%s' \n"
+                "def extWorkspace = exwsAllocate '%s' \n"
                         + "node ('linux') { \n"
                         + "	exws (extWorkspace) { \n"
                         + "		try { \n"

diff --git a/src/test/java/plugins/GradlePluginTest.java b/src/test/java/plugins/GradlePluginTest.java
@@ -135,7 +135,7 @@ private Build setUpAndRunPipelineBuild(final String jenkinsFile, final String gr
         final WorkflowJob workflowJob = jenkins.jobs.create(WorkflowJob.class);
 
         String copyResourceStep = workflowJob.copyResourceStep(gradleScript);
-        String test = "" + "pipeline {\n"
+        String test = "pipeline {\n"
                 + "agent any\n"
                 + "stages {\n"
                 + "stage ('prepare_build') {\n"