Remove workaround for JENKINS-73900 in CspRule
#1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
reviewed
Nov 5, 2024
basil
changed the title
CspRule
basil
changed the title
CspRuleCspRule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
Removed workaround for JENKINS-73900 in CspRule.java
Description:
This pull request addresses an outdated workaround for JENKINS-73900 within the CspRule.java file in the acceptance test harness.
Changes:
Removed the conditional code that was bypassing CSP report checks specifically for SubversionPluginTest.
With this workaround removed, SubversionPluginTest will now be subject to the same CSP checks as other tests in CspRule.java.
Issue Reference:
Fixes JENKINS-73900
Testing:
Verified that the tests run successfully after the removal.
Ran mvn test to confirm that the modification does not introduce new errors.
Additional Notes:
Maintainers may wish to ensure compatibility with other plugins, as this change affects SubversionPluginTest specifically.
Fixes #1810