Initial version. Allow to disable any select option with :disable #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, that sounds interesting! Code-wise it looks good, will need to run the plugin later to see if everything works fine (cc @imoutsatsos), but looks like a good issue for the next release. Thanks @ivarmu ! |
|
(the code actually looks really good! Thanks for the comments and tests!) |
kinow
reviewed
Jul 25, 2019
| </j:invokeStatic> | ||
| <j:choose> | ||
| <j:when test="${selected}"> | ||
| <f:option selected="${selected}" value="${escapedKey}">${escapedValue}</f:option> |
There was a problem hiding this comment.
Oh, funny, we didn't have that for selected before.
kinow
approved these changes
Jul 25, 2019
There was a problem hiding this comment.
Worked for me. Now just up for @imoutsatsos to have a go as well, but otherwise good to be merged IMO.
Thanks again @ivarmu
|
Hi @imoutsatsos, could you please review that PR? Thanks in advance! |
|
@ivarmu I think he might be busy, but I did some testing and it worked. Will merge and release over the weekend, so you should have this new feature next week 👍 |
|
Merged, releasing probably tomorrow night, or Saturday NZ time. Thanks for your PR @ivarmu ! Check out your plugin updates on Monday 👍 |
|
Hi! I want to have a selected and disabled elements. But when I try to combine both options, it doesn't work. Is there such possibility? |
|
I only added the possibility of getting disabled elements to the already
existing possibility of having them selected, but didn't consider to have
both options at the same time... should be interesting having a selected
and disabled element (only one could be in that situation)?
El mié., 18 mar. 2020 9:18, SciMan72 <notifications@github.com> escribió:
… Hi! I want to have a selected and disabled elements. But when I try to
combine both options, it doesn't work. Is there such possibility?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMULG6I7NOCCWOV3JMDXELRIB7TRANCNFSM4IGOMMTA>
.
|
|
Is it possible to have this feature in the next version?On 18 Mar 2020 18:37, Ivan Aragonés Muniesa <notifications@github.com> wrote:
I only added the possibility of getting disabled elements to the already
existing possibility of having them selected, but didn't consider to have
both options at the same time... should be interesting having a selected
and disabled element (only one could be in that situation)?
El mié., 18 mar. 2020 9:18, SciMan72 <notifications@github.com> escribió:
Hi! I want to have a selected and disabled elements. But when I try to
combine both options, it doesn't work. Is there such possibility?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMULG6I7NOCCWOV3JMDXELRIB7TRANCNFSM4IGOMMTA>
.
—You are receiving this because you commented.Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I'll do my best in that... in Spain we are confined right now and the
children claim all the free time :-)
El mié., 18 mar. 2020 19:04, SciMan72 <notifications@github.com> escribió:
… Is it possible to have this feature in the next version?On 18 Mar 2020
18:37, Ivan Aragonés Muniesa ***@***.***> wrote:
I only added the possibility of getting disabled elements to the already
existing possibility of having them selected, but didn't consider to have
both options at the same time... should be interesting having a selected
and disabled element (only one could be in that situation)?
El mié., 18 mar. 2020 9:18, SciMan72 ***@***.***> escribió:
> Hi! I want to have a selected and disabled elements. But when I try to
> combine both options, it doesn't work. Is there such possibility?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <
#25 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AGMULG6I7NOCCWOV3JMDXELRIB7TRANCNFSM4IGOMMTA
>
> .
>
—You are receiving this because you commented.Reply to this email
directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGMULG6LV4QBA6EU7YUS573RIEEMLANCNFSM4IGOMMTA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to let to show disabled options at SELECT (Single select, Multi select, radio buttons and check boxes)
The syntax provided is the same one used to select one or more options:
["A", "B:selected", "C:disabled"]