Use symbol instead of PNG file for Active Directory health #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
basil
reviewed
Apr 28, 2025
| <l:layout title="${it.displayName}"> | ||
| <l:main-panel> | ||
| <h1><img style="width:32px; height:32px" src="${resURL}/plugin/active-directory/images/icon.png"/> ${it.displayName}</h1> | ||
| <h1><l:icon src="symbol-medkit-outline plugin-ionicons-api" class="icon-xlg" /> ${it.displayName}</h1> |
Member
There was a problem hiding this comment.
Should sub-pages have an icon in the <h1> tag at all? Not sure what current guidance is from @jenkinsci/sig-ux.
Member
There was a problem hiding this comment.
https://weekly.ci.jenkins.io/design-library/symbols/ (not necessarily the clearest spot for it...)
They shouldn't, they should be used in unique cases, such as builds or user profiles.
6 tasks
basil
reviewed
Apr 28, 2025
src/main/resources/hudson/plugins/active_directory/ActiveDirectoryStatus/index.jelly
Outdated
Show resolved
Hide resolved
…toryStatus/index.jelly
basil
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cosmetic change to use a themable symbol instead of .png file for the AD health
Testing done
Before
After
Submitter checklist