56737 - Allow timestamps preceding javac warnings #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Javac warnings were not matched if a timestamp preceded the message. Example: 08:52:34.395 [WARNING] /my/path/to/workspace/src/main/..... Warnings with timestamps will now be matched. The preceeding word has to to be a arbitrary number of characters that are no whitespace followed by one whitespace. It is not checked if the preceding word is a timestamp at all because of the varous timestamp formats that are allowed.
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
=========================================
Coverage 87.89% 87.89%
Complexity 1211 1211
=========================================
Files 157 157
Lines 3865 3865
Branches 424 424
=========================================
Hits 3397 3397
Misses 311 311
Partials 157 157
Continue to review full report at Codecov.
|
uhafner
approved these changes
Apr 1, 2019
|
Can you please add a line to the ChangeLog as well (with links to PR and issue)? See existing entries for an example. |
|
Prima! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue https://issues.jenkins-ci.org/browse/JENKINS-56737
Javac warnings were not matched if a timestamp preceded the message.
Example:
08:52:34.395 [WARNING] /my/path/to/workspace/src/main/java/my/package/TemporalJsonSeqFiling.java:[86,76] redundant cast to long
Solution:
Warnings with timestamps will now be matched. The preceding word has to to be a arbitrary number of characters that are no whitespace followed by one whitespace. It is not checked if the preceding word is a timestamp at all because of the various timestamp formats that are allowed.